handle mysql master / slave connection #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonCallisto
force-pushed
the
master
branch
2 times, most recently
from
5ff0587 to
f844c76
Compare
|
I didn't had the chance to take a look at this. Would you mind to rebase this? |
|
@DonCallisto rebase done. Take the time you need for the review, I'm using my patched version for the moment. Thanks for maintaining this library ! |
|
Doing my best with my little free time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, the
$dbNameis computed either from$params['dbname']on$params['master']['dbname']and override only thedbnameparameter (not themasterone) and there is no slave management except for sqlite.This PR compute the dbname from the mysql connection and replace both dbname, master's dbname and all slaves dbname.
I test if the driver is
pdo_mysql, but it might be the default case, what do you think ?